Fix issue with reading from synced file in a sharepoint folder #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

FraserGreenroyd merged 1 commit into develop from Excel_Toolkit-#20-FixReadFromOpenFileInSyncedSharepointFolder

Apr 14, 2023

Contributor

IsakNaslundBh commented Apr 3, 2023

Issues addressed by this PR

Closes #20

Adding FileShare.Delete to the FileShare enum when constructing the filestream. Fixes issues of unable to access file when trying to read from a file in a synced Sharepoint folder.

Test files

Sync a Shaprepoint folder with an excel file
Open the file
Read from the file

Changelog

Additional comments


          Fix issue with reading from synced file in a sharepoint folder

5d7fedc

IsakNaslundBh added the type:bug label

IsakNaslundBh requested a review from adecler

April 3, 2023 07:53

IsakNaslundBh self-assigned this

adecler reviewed

View reviewed changes

Member

adecler left a comment

As discussed, this will have to be tested by someone with a working OneDrive but I am happy with the change from the perspective of the code.

FraserGreenroyd self-requested a review

April 13, 2023 10:22

FraserGreenroyd approved these changes

View reviewed changes

FraserGreenroyd left a comment

I have reviewed the code and am happy with that.

I ran a test on today's alpha, and managed to replicate the issue described in #20 . I then ran the same test on this PR, and the issue went away, with the Excel file contents being pulled suitably into Grasshopper with the file from SharePoint open in Excel at the same time.

This PR therefore brings an enhancement to the process so I am happy to see this deployed.

FraserGreenroyd commented Apr 14, 2023

@BHoMBot check compliance

bhombot-ci bot commented Apr 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

check code-compliance
check documentation-compliance
check project-compliance
check branch-compliance
check dataset-compliance
check copyright-compliance

There are 2 requests in the queue ahead of you.

FraserGreenroyd commented Apr 14, 2023

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

bhombot-ci bot commented Apr 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

check core
check null-handling
check serialisation

There are 18 requests in the queue ahead of you.

FraserGreenroyd commented Apr 14, 2023

@BHoMBot check versioning

bhombot-ci bot commented Apr 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

check versioning

FraserGreenroyd commented Apr 14, 2023

@BHoMBot check installer

bhombot-ci bot commented Apr 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

check installer

There are 2 requests in the queue ahead of you.

FraserGreenroyd commented Apr 14, 2023

@BHoMBot check ready-to-merge

bhombot-ci bot commented Apr 14, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

check ready-to-merge

FraserGreenroyd merged commit 1cde8ed into develop

FraserGreenroyd deleted the Excel_Toolkit-#20-FixReadFromOpenFileInSyncedSharepointFolder branch

April 14, 2023 12:22

bhombot-ci bot mentioned this pull request

6.2 Deployment #32

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels